Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: jansCodeChallengeHash should be defiend as Integer #7744

Merged
merged 4 commits into from
Feb 16, 2024
Merged

fix: jansCodeChallengeHash should be defiend as Integer #7744

merged 4 commits into from
Feb 16, 2024

Conversation

yurem
Copy link
Contributor

@yurem yurem commented Feb 15, 2024

@yurem
fix: jansCodeChallengeHash should be defiend as Integer
1ba2ada 
Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
@yurem yurem enabled auto-merge (squash) February 15, 2024 20:23
@mo-auto mo-auto added comp-jans-fido2 Component affected by issue or PR comp-jans-orm Component affected by issue or PR comp-jans-scim Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Feb 15, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed for 'SCIM API'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Milton-Ch
Copy link
Contributor

@yurem

I've tested this PR in the dev environment, using postgresql and it is already working.

image

@yurem yurem requested a review from yuremm February 16, 2024 08:59
@yuremm
Copy link
Contributor

yuremm commented Feb 16, 2024

@Milton-Ch Thank you for testing it

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed for 'jans-cli'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed for 'orm'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yurem yurem merged commit 6337fdb into main Feb 16, 2024
1 of 2 checks passed
@yurem yurem deleted the issue_7701 branch February 16, 2024 12:18
shekhar16
shekhar16 reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@shekhar16 shekhar16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

yurem added a commit that referenced this pull request Feb 20, 2024
@yurem
fix: jansCodeChallengeHash should be defiend as Integer (#7744)
e9423b8 
Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
devrimyatar pushed a commit that referenced this pull request Feb 27, 2024
@yurem @devrimyatar
fix: jansCodeChallengeHash should be defiend as Integer (#7744)
bce15a2 
Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhar16 shekhar16 shekhar16 left review comments

@yuriyz yuriyz yuriyz approved these changes

@jgomer2001 jgomer2001 jgomer2001 approved these changes

@yuremm yuremm yuremm approved these changes

Assignees
No one assigned
Labels
comp-jans-fido2 Component affected by issue or PR comp-jans-orm Component affected by issue or PR comp-jans-scim Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@yurem @Milton-Ch @yuremm @yuriyz @jgomer2001 @shekhar16 @mo-auto @moabu